Path to Stage 4:

[mgaudet]

Template borrowed from here; Thanks Dan!

Stage 4

• committee approval
• two implementations and significant in-the-field experience
• ecma262 PR approved
• prepare ecma262 PR

Stage 3

• committee approval
• merge test262 tests
• write test262 tests

Stage 2.7

• committee approval
• spec editor signoff
  • [ ]
• spec reviewer signoff
  • Jordan
  • Justin

[mgaudet]

@ljharb / @jridgewell

Would you be able to look at the current spec text? I'd like to put this on the Agenda for July for 2.7

[ljharb]

It doesn't make sense to me that HasPropertyWhichCouldRunUserCode would ignore setters, since that also means it has a property that could run user code. It should probably take an enum value - ~get~, ~set~, or ~both~ - and check the appropriate fields? (even though we'd only be using one branch)

Separately, the style used in [[HasProperty]] would mean that HasPropertyWhichCouldRunUserCode should, instead of a while loop, do return HasPropertyWhichCouldRunUserCode(o.[[GetPrototypeOf]](), _propertyKey_)

PerformPromiseResolution is a net new AO, which should mean all of the steps are <ins>, but only steps 1 and 8 are marked green.

Otherwise, everything looks good.

[bakkot]

@ljharb Would your concerns be addressed by renaming the AO to "ReadingPropertyCouldRunUserCode"?

[ljharb]

Sure, that's not nearly as elegant but it certainly avoids serving an unused purpose.

[mgaudet]

Sorry for the long delay

1. Updated the spec text so all new AOs are in
2. HasPropertyWhichCouldRunUserCode is now recursive, and simply checks for an accessor. I can refine to an enum if necessary, but IMO this is sufficient for this purpose.

[mgaudet]

Had a burst of energy this morning and so added the enum; back to getter only

[ljharb]

• Why would null have a property that could run user code?
• i don't think we need the spidermonkey reference in the actual spec (ignore this if it's just for the proposal)
• in RequiresDeferredPromiseResolution step 4, should it be "if thenValue is a function object"?

Otherwise, looks good!

[mgaudet]

• Why would null have a property that could run user code?

PEBKAC unfortunately during recursion change I think

• in RequiresDeferredPromiseResolution step 4, should it be "if thenValue is a function object"?

IsCallable matches the verbiage in CreateResolvingFunctions; as well, I think we still want to trap on host objects with [[Call]] internal slots document.all

[mgaudet]

Fixed in 1aefd18

[ljharb]

The definition of IsCallable matches that of "function object" - so I'd expect we'd use one or the other consistently.

[mgaudet]

So it does. How funky (mostly because document.all is super funky, but I didn't realize they were synonyms)