Skip to content

added remove method for selectionMenu, add method now return an item - #2761

Open
vikramgaming wants to merge 2 commits into
Acode-Foundation:mainfrom
vikramgaming:selectionMenu
Open

added remove method for selectionMenu, add method now return an item#2761
vikramgaming wants to merge 2 commits into
Acode-Foundation:mainfrom
vikramgaming:selectionMenu

Conversation

@vikramgaming

Copy link
Copy Markdown

No description provided.

@greptile-apps

greptile-apps Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR extends the selection-menu API while correcting the initialization failure identified in the previous review.

  • Returns the registered menu item from selectionMenu.add.
  • Adds identity-based removal through selectionMenu.remove.
  • Renames the local binding so add can invoke the module-level item factory safely.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
src/lib/selectionMenu.js Adds return and removal support for menu items, and fully resolves the previously reported item-factory shadowing failure.

Reviews (2): Last reviewed commit: "Update src/lib/selectionMenu.js" | Re-trigger Greptile

Comment thread src/lib/selectionMenu.js Outdated
@bajrangCoder

Copy link
Copy Markdown
Member

What's the point of changing add method stuffs

@vikramgaming

vikramgaming commented Aug 17, 2026

Copy link
Copy Markdown
Author

@bajrangCoder sometimes when I make plugins, we can add a selectionMenu but we cannot remove it.

so what if the add method return the menuItem and that menuItem can be used to remove the selectionMenu from items?

Sorry if my English is bad, I'm using a translate app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

2 participants