[EMCAL-1156] Modernize EMCal code and fix Digitizer - #15706
Open
mhemmer-cern wants to merge 3 commits into
Open
Conversation
- Moderinze EMCal code: EMCALBase/Geometry and ClusterFactory Classes and DataFormatsEMCAL classes, removing c-style arrays - Fixing clang-tidy warnings and errors that would appear when using the O2Physics clang-tidy settings - Switching from gsl::span to std::span to use official stl container [EMCAL] update
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a bug in the Digitizer where
iLabelwas initialized at 0 and the incrementation in the loop was skipped due to always continue if the value is 0 without incrementing the value. Local testing showed that while it is clearly a logic bug, it did not effect MC production.Modernize EMCal code: EMCALBase/Geometry and ClusterFactory Classes and DataFormatsEMCAL classes:
Fix return type for getCoreRadius (was bool should be float) and argument type for setUseWeightExotic(float useWeightExotic which should be setUseWeightExotic(bool useWeightExotic).
Removes streaming of spans from ROOT IO in ClusterFactory, since they are non owing spans.
Fixed some argument name differences between the definition and implementation of some functions.