chore - #42
Closed
kshahbw wants to merge 1 commit into
Closed
Conversation
This repository is public. The 10DLC test fixtures were captured from a live brand record and carried real values into it: - two Bandwidth employee email addresses, in brand fixtures - a real EIN, in four files - two real brand IDs (104 and 8 occurrences) - the internal display name of the acceptance-test brand - two references to an internal ticket key The email addresses are the reason this is worth a commit on its own. One belongs to a colleague who is not a contributor here and did not consent to having their work address published; the rest is internal-facing detail that a public repo has no reason to carry. Substitutions are identity-preserving. The two new brand-ID placeholders use unused BEXMPL slots rather than BEXMPL1/BEXMPL2, which already denote distinct brands -- reusing those would have merged two identities inside cmd/tendlc/brand_test.go, where both appear. Verified: build, full suite, gofmt and golangci-lint all clean, and a break-and-restore check confirms the renamed fixtures still discriminate (planting a wrong ID fails TestBrandUpdatePrintsAcceptanceReceiptWith- IDsAndLatencyNote) -- the rename did not neuter the assertions. Note this does not remove the values from git history, which is public and already fetched. It stops them propagating into the docsite, the next release, and search indexing.
kshahbw
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.