chore(test): use placeholder values in fixtures - #43
Merged
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
The 10DLC fixtures were seeded from a captured record and carried its values along with it. Swap them for placeholders so the fixtures are self-contained and carry nothing incidental. Substitutions are identity-preserving. The two new brand-ID placeholders use unused BEXMPL slots rather than BEXMPL1/BEXMPL2, which already denote distinct brands and both appear alongside the replaced ID in cmd/tendlc/brand_test.go -- reusing those would have merged two identities. Verified: build, full suite, gofmt and golangci-lint clean, plus a break-and-restore check confirming the renamed fixtures still discriminate rather than passing vacuously.
kshahbw
force-pushed
the
chore/test-fixture-placeholders
branch
from
August 24, 2026 18:54
973e108 to
d89c6a8
Compare
achandras
approved these changes
Aug 24, 2026
krocc
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 10DLC fixtures were seeded from a captured record and carried its values along with it. This swaps them for placeholders so the fixtures are self-contained and carry nothing incidental.
Substitutions are identity-preserving — no test semantics change.
The two new brand-ID placeholders use unused
BEXMPLslots rather thanBEXMPL1/BEXMPL2. Those already denote distinct brands and both appear alongside the replaced ID incmd/tendlc/brand_test.go, so reusing them would have quietly merged two identities in a test.Verified:
go build, full suite,gofmtandgolangci-lintall clean. A break-and-restore check confirms the renamed fixtures still discriminate — planting a wrong ID failsTestBrandUpdatePrintsAcceptanceReceiptWithIDsAndLatencyNote— so the rename did not neuter the assertions.