Skip to content

Migrate from Sprockets to Propshaft - #46

Merged
awilfox merged 1 commit into
mainfrom
awilfox/AP-808-migrate-off-node
Aug 18, 2026
Merged

Migrate from Sprockets to Propshaft#46
awilfox merged 1 commit into
mainfrom
awilfox/AP-808-migrate-off-node

Conversation

@awilfox

@awilfox awilfox commented Aug 17, 2026

Copy link
Copy Markdown
Member
  • We don't actually need a JavaScript runtime installed at all.
    • We don't transpile nor bundle anything.
    • dartsass handles the CSS compilation.
    • remove Yarn stuff from .gitignore since we don't use it any more.
  • Update hardcoded asset paths to use helpers as appropriate.
  • Remove unused code (empty application.js, Sprockets config, et c.)
  • Use Ruby ~> 3.4 instead of hardcoding 3.4.9.
  • Use SECRET_KEY_BASE_DUMMY instead of SECRET_KEY_BASE when precompiling assets in Docker.
  • Update JSON Gem for vulnerability while we're here.
  • Ensure Compose builds the Development target.

Implements: AP-808

@awilfox awilfox self-assigned this Aug 17, 2026
@awilfox
awilfox force-pushed the awilfox/AP-808-migrate-off-node branch from e38b370 to 5c91b8b Compare August 17, 2026 23:16

@anarchivist anarchivist left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one specific question about precompiling assets for dev, but other than that i'd say it looks good. inspecting the dartsass:build logs, it looks like we've got a bunch of deprecation warnings about using / as a division operator, but i suppose we could handle that separately.

Comment thread Dockerfile
Comment thread Dockerfile Outdated
@awilfox
awilfox force-pushed the awilfox/AP-808-migrate-off-node branch from 5c91b8b to dab2871 Compare August 18, 2026 15:50
@awilfox

awilfox commented Aug 18, 2026

Copy link
Copy Markdown
Member Author

v2:

  • remove yarn from .gitignore and a missed postCSS config file that is unused.
  • update JSON gem for CVE
  • use SECRET_KEY_BASE_DUMMY instead of SECRET_KEY_BASE in Docker.

@awilfox
awilfox force-pushed the awilfox/AP-808-migrate-off-node branch from dab2871 to cf3e024 Compare August 18, 2026 15:54
@awilfox

awilfox commented Aug 18, 2026

Copy link
Copy Markdown
Member Author

v3:

  • Update CHANGES.md with changes.

* We don't actually need a JavaScript runtime installed at all.

  * We don't transpile nor bundle anything.

  * dartsass handles the CSS compilation.

  * remove Yarn stuff from .gitignore since we don't use it any more.

* Update hardcoded asset paths to use helpers as appropriate.

* Remove unused code (empty application.js, Sprockets config, et c.)

* Use Ruby ~> 3.4 instead of hardcoding 3.4.9.

* Use `SECRET_KEY_BASE_DUMMY` instead of `SECRET_KEY_BASE` when
  precompiling assets in Docker.

* Update JSON Gem for vulnerability while we're here.

* Ensure Compose builds the Development target.

Implements: AP-808
@awilfox
awilfox force-pushed the awilfox/AP-808-migrate-off-node branch from cf3e024 to a3a147e Compare August 18, 2026 16:48
@awilfox

awilfox commented Aug 18, 2026

Copy link
Copy Markdown
Member Author

v4:

  • change docker-compose.yml to use the development target like other apps. found while debugging the asset issue above, but doesn't change anything locally (both targets work correctly for me)

@awilfox
awilfox merged commit a3a147e into main Aug 18, 2026
5 checks passed
@awilfox
awilfox deleted the awilfox/AP-808-migrate-off-node branch August 18, 2026 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants