Migrate from Sprockets to Propshaft - #46
Merged
Merged
Conversation
awilfox
requested review from
anarchivist,
danschmidt5189,
davezuckerman and
jason-raitz
August 17, 2026 23:12
awilfox
force-pushed
the
awilfox/AP-808-migrate-off-node
branch
from
August 17, 2026 23:16
e38b370 to
5c91b8b
Compare
anarchivist
approved these changes
Aug 18, 2026
anarchivist
left a comment
Member
There was a problem hiding this comment.
one specific question about precompiling assets for dev, but other than that i'd say it looks good. inspecting the dartsass:build logs, it looks like we've got a bunch of deprecation warnings about using / as a division operator, but i suppose we could handle that separately.
awilfox
force-pushed
the
awilfox/AP-808-migrate-off-node
branch
from
August 18, 2026 15:50
5c91b8b to
dab2871
Compare
Member
Author
|
v2:
|
awilfox
force-pushed
the
awilfox/AP-808-migrate-off-node
branch
from
August 18, 2026 15:54
dab2871 to
cf3e024
Compare
Member
Author
|
v3:
|
* We don't actually need a JavaScript runtime installed at all. * We don't transpile nor bundle anything. * dartsass handles the CSS compilation. * remove Yarn stuff from .gitignore since we don't use it any more. * Update hardcoded asset paths to use helpers as appropriate. * Remove unused code (empty application.js, Sprockets config, et c.) * Use Ruby ~> 3.4 instead of hardcoding 3.4.9. * Use `SECRET_KEY_BASE_DUMMY` instead of `SECRET_KEY_BASE` when precompiling assets in Docker. * Update JSON Gem for vulnerability while we're here. * Ensure Compose builds the Development target. Implements: AP-808
awilfox
force-pushed
the
awilfox/AP-808-migrate-off-node
branch
from
August 18, 2026 16:48
cf3e024 to
a3a147e
Compare
Member
Author
|
v4:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SECRET_KEY_BASE_DUMMYinstead ofSECRET_KEY_BASEwhen precompiling assets in Docker.Implements: AP-808