[bugfix] Fix progress bar accuracy for VFR videos - #562
Open
nathanmdan wants to merge 2 commits into
Open
Conversation
Owner
|
Hi @nathanmdan; just checking in, are you okay making the changes I asked for? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses progress bar behavior mentioned in Issue Scene list has invalid end time for variable frame rate DVDs #561 where progress bar only goes up to ~80% with VFR videos, even with PyAV backend.
Progress bar now goes up to 100% for both PyAV and OpenCV backends.
Please note that this PR does not address the main topic of Issue Scene list has invalid end time for variable frame rate DVDs #561 (Invalid end time in scene lists for VFR videos) which was determined to be unique to the OpenCV backend and is not present when using PyAV.