Admin Sidebar: support optional icons for extendable submenu - #6115
Open
MMilosz wants to merge 3 commits into
Open
Admin Sidebar: support optional icons for extendable submenu#6115MMilosz wants to merge 3 commits into
MMilosz wants to merge 3 commits into
Conversation
MMilosz
force-pushed
the
feat/admin-sidebar/support-icons-in-submenu
branch
from
August 21, 2026 19:50
25f04db to
bdb5321
Compare
MMilosz
force-pushed
the
feat/admin-sidebar/support-icons-in-submenu
branch
from
August 21, 2026 20:17
bdb5321 to
83f484d
Compare
MMilosz
marked this pull request as ready for review
August 21, 2026 21:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Description
This PR adds icon support to extendable submenu items in the admin sidebar.
Please note this PR does not add any new icons!
Example
Instructions for Reviewers
Changes in this PR:
iconproperty to extendable submenu item configuration for every instance ofMenuItemModelMenuItemModels rendering logic to display icons when providedAltmetricMenuItemModelandSearchMenuItemModelwere not updated due to their specific use cases (they are not used in the extendable submenu anyway)LinkMenuItem&OnclickMenuItem) to validate the icon rendering supportHow to Test
Please note DSpace does not have built-in validation to verify if a FontAwesome icon string actually exists. This PR does not change that.
During tests, please ensure that:
iconproperty (check the configuration example below)To fully test this PR, you can add new icons in submenu: go to any inheritor of
AbstractExpandableMenuProviderand inside amodeldefine a value foricon: '...'.Example
LLM Disclosure
Instructed local Qwen3.8:27B to write tests & test compliance with CODE_CONVENTIONS.md & check browser compatibility before submitting the PR. The rest is my own work (meaning pretty much copy-pasted from the existing DSpace components 😉)
Checklist
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.