Consolidate FIB workflow - #872
Open
tieneupin wants to merge 7 commits into
Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #872 +/- ##
==========================================
- Coverage 54.92% 54.70% -0.22%
==========================================
Files 101 101
Lines 11329 11286 -43
Branches 1501 1498 -3
==========================================
- Hits 6222 6174 -48
- Misses 4779 4785 +6
+ Partials 328 327 -1 🚀 New features to boost your workflow:
|
tieneupin
marked this pull request as ready for review
August 24, 2026 10:42
…e_metadata' in 'murfey.util.fib'
tieneupin
force-pushed
the
consolidate-fib-workflow
branch
from
August 24, 2026 10:43
e10638d to
e90f22c
Compare
…tion, since other functions in the module are used on the client side
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Housekeeping PR following on from PR #868 .
We have established that the electron snapshot images (Maps) and the lamella evaluation images (AutoTEM) stored their metadata using identical XML schemas. Given the identical extraction logic, barring metadata location differences for the different file formats, it seems sensible to migrate the logic out into a helper function that can be reused in the different workflows, and can be further extended to support other file and metadata schema formats.
The metadata extraction logic has remained largely unchanged, but some logic was added beforehand to identify the file format and where to extract the metadata from.
The majority of the diff comes from the migration and deletion of tests. Actual code diff is +198/-285.