Skip to content

Consolidate FIB workflow - #872

Open
tieneupin wants to merge 7 commits into
mainfrom
consolidate-fib-workflow
Open

Consolidate FIB workflow#872
tieneupin wants to merge 7 commits into
mainfrom
consolidate-fib-workflow

Conversation

@tieneupin

@tieneupin tieneupin commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Housekeeping PR following on from PR #868 .

We have established that the electron snapshot images (Maps) and the lamella evaluation images (AutoTEM) stored their metadata using identical XML schemas. Given the identical extraction logic, barring metadata location differences for the different file formats, it seems sensible to migrate the logic out into a helper function that can be reused in the different workflows, and can be further extended to support other file and metadata schema formats.

The metadata extraction logic has remained largely unchanged, but some logic was added beforehand to identify the file format and where to extract the metadata from.

The majority of the diff comes from the migration and deletion of tests. Actual code diff is +198/-285.

@codecov

codecov Bot commented Aug 24, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 82.05128% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.70%. Comparing base (936d462) to head (19f8e80).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #872      +/-   ##
==========================================
- Coverage   54.92%   54.70%   -0.22%     
==========================================
  Files         101      101              
  Lines       11329    11286      -43     
  Branches     1501     1498       -3     
==========================================
- Hits         6222     6174      -48     
- Misses       4779     4785       +6     
+ Partials      328      327       -1     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tieneupin tieneupin self-assigned this Aug 24, 2026
@tieneupin tieneupin added enhancement New feature or request server Relates to the server component fib Part of the FIB pipeline extension labels Aug 24, 2026
@tieneupin
tieneupin marked this pull request as ready for review August 24, 2026 10:42
@tieneupin
tieneupin force-pushed the consolidate-fib-workflow branch from e10638d to e90f22c Compare August 24, 2026 10:43
…tion, since other functions in the module are used on the client side
@tieneupin tieneupin changed the title Consolidate fib workflow Consolidate FIB workflow Aug 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request fib Part of the FIB pipeline extension server Relates to the server component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant