BAM bugfix (answer-changing BAM only); fix history unit; sync some files to CAM-SIMA abstract interface - #1652
Open
jimmielin wants to merge 11 commits into
Open
BAM bugfix (answer-changing BAM only); fix history unit; sync some files to CAM-SIMA abstract interface#1652jimmielin wants to merge 11 commits into
jimmielin wants to merge 11 commits into
Conversation
jimmielin
changed the title
jimmielin
changed the title
fvitt
requested changes
Aug 19, 2026
fvitt
left a comment
fvitt
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the bug fix and other clean ups. Since you are changing answers for BAM with this PR, can you also include mods to romove the special bit-for-bit bam code here:
Collaborator
Author
|
Thanks @fvitt, now removed! |
Collaborator
Author
|
Since this will change answers inside microp_aero (affects nucleate_ice) I am recreating |
fvitt
approved these changes
Aug 19, 2026
fvitt
left a comment
fvitt
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me. Thanks.
…%MT%CT4S2_CLM60%SP_CICE%PRES_DOCN%DOM_MOSART_SGLC_SWAV_SESP
jimmielin
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1597 - this is answer changing for interactive BAM
See
src/chemistry/aerosol/bulk_aerosol_state_mod.F90Fixes #1608
Other are just adding missing DOIs and
nullify()on destructorFixes #1653 for nvhpc test to now pass again