[No QA] Docs updates for E/A#97883 Document Send to someone for tracked expenses - #99130
Draft
MelvinBot wants to merge 1 commit into
Draft
[No QA] Docs updates for E/A#97883 Document Send to someone for tracked expenses#99130MelvinBot wants to merge 1 commit into
MelvinBot wants to merge 1 commit into
Conversation
Co-authored-by: Shawn Borton <shawnborton@users.noreply.github.com>
40 tasks
Contributor
|
A preview of your ExpensifyHelp changes have been deployed to https://6b8914fb.helpdot.pages.dev ⚡️ Updated articles: |
Contributor
|
Seems good to me 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
This PR updates the Track Expenses help article to document the new Send to someone option added to a tracked expense's More menu in Expensify/App#97883.
Previously the article only described submitting a tracked expense via the Concierge actionable message in the Expense Chat, plus the click-into options available to workspace members. The merged change adds a Send to someone row at the top of the More menu when viewing an unreported tracked expense in Spend > Expenses, giving users a direct path to submit it to a recipient (no workspace required). This PR adds a
## How to send a tracked expense to someonesection covering that flow and extends the frontmatter keywords for retrieval. Bug 1 in the source PR (where a "Something else" user lands after creating an expense) is internal navigation behavior and doesn't change any documented workflow, so no doc update was needed for it.Applied
docs/HELPSITE_NAMING_CONVENTIONS.md,docs/HELP_AUTHORING_GUIDELINES.md, anddocs/TEMPLATE.md. UI labels (Spend > Expenses, More, Send to someone) were verified against the source translation strings insrc/languages/en.ts(common.more= "More",iou.sendToSomeone= "Send to someone"). Live-UI verification could not be completed this run because the dev web app was stuck on the boot splash and sign-in was unavailable — please confirm the labels/flow against the current UI when reviewing.Fixed Issues
$ #97883
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review".
// Please describe what tests you performed that validate your changes worked.
Offline tests
QA Steps
// TODO: The human co-author must fill out the QA tests before marking this PR as "ready for review", or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@shawnborton, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.