Fix accounting software input not visible in landscape mode when keyboard is opened - #99157
Conversation
|
@codex please review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 84bdc1f00f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@ahmedGaber93 @truph01 One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@truph01 this is a follow-up PR, so please skip reviewing it. |
|
@ahmedGaber93 Have you started reviewing it? If not, I've reviewed it and will take over it since it is also the follow up in the landscape mode project? |
| ); | ||
| } | ||
|
|
||
| const shouldContinueButtonBeFixed = keyboardActiveHeight === 0 || !isInLandscapeMode; |
There was a problem hiding this comment.
Reuse the isKeyboardActive boolean?
useKeyboardState already exposes isKeyboardActive — could we use !isKeyboardActive || !isInLandscapeMode here instead of comparing keyboardActiveHeight === 0? Reads a bit more directly.
There was a problem hiding this comment.
makes sense, I've been using keyboardActiveHeight lately and I didn't notice that in this case using isKeyboardActive is more clear
|
@truph01 No, I haven’t started reviewing it yet. Feel free to take it over. |
Sure, thanks! |
joekaufmanexpensify
left a comment
There was a problem hiding this comment.
Fixing deploy blocker
Explanation of Change
On the onboarding accounting step in landscape mode, the "Other" accounting software text input was hidden behind the keyboard.
BaseOnboardingAccountingnow wraps the header/title inCollapsibleHeaderOnKeyboardand, while the keyboard is open in landscape, moves the Continue button out ofFixedFooterinto theScrollViewso that it's not pushed above the keyboard that would cover the input.Fixed Issues
$ #98832
PROPOSAL: N/A
Tests
Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-08-21.at.10.05.12.mov
iOS: Native
Screen.Recording.2026-08-21.at.10.07.36.mov