fix: clamp GDI char dimensions in Store_GDI_Char - #572
Open
seer-by-sentry[bot] wants to merge 1 commit into
Open
fix: clamp GDI char dimensions in Store_GDI_Char#572seer-by-sentry[bot] wants to merge 1 commit into
seer-by-sentry[bot] wants to merge 1 commit into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
FontCharsClass::Store_GDI_Charfunction inrender2dsentence.cppwas susceptible to an out-of-bounds read fromGDIBitmapBits. This occurred becauseGetTextExtentPoint32Wcould return character dimensions (char_size.cxandchar_size.cy) that exceeded the pre-allocatedGDIBitmapbuffer'swidth(PointSize * 2) orCharHeight.This fix introduces clamping for
char_size.cxandchar_size.cyimmediately afterGetTextExtentPoint32Wis called andPixelOverlap/xOriginadjustments are made.char_size.cxis clamped towidthandchar_size.cyis forced toCharHeight. This ensures that subsequent loops iterating over the bitmap data (for (int row = 0; row < char_size.cy; row ++) { ... for (int col = 0; col < char_size.cx; col ++) { ... } }) operate strictly within the allocated buffer bounds, preventing the out-of-bounds access and associated crashes.Fixes CLIENT-53X
This PR was automatically generated by Sentry. You can adjust this setting at any time.