fix(linux): restore PlayStation gamepad hotplug in Steam - #85
Merged
Conversation
Linux UHID now rewrites requested PlayStation USB profiles (DualShock 4 and DualSense) to their Bluetooth transport variants so Steam's hidraw access rules can match virtual devices correctly. The backend preserves caller-provided identity/capability metadata while swapping bus and report framing fields, returns the effective profile from gamepad creation, and leaves non-PlayStation or already-Bluetooth requests unchanged. Added test hooks and unit coverage for the profile translation behavior, and documented the Linux-only transport adjustment.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #85 +/- ##
==========================================
+ Coverage 75.03% 75.04% +0.01%
==========================================
Files 34 34
Lines 8050 8083 +33
Branches 3012 3029 +17
==========================================
+ Hits 6040 6066 +26
+ Misses 1671 1473 -198
- Partials 339 544 +205
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Harness.
|
ReenigneArcher
force-pushed
the
fix/linux/playstation-pads
branch
from
August 16, 2026 00:40
8e5426a to
de59e55
Compare
ReenigneArcher
changed the title
Switch Linux UHID PlayStation handling from transport/profile rewriting to identity-only naming. DualShock 4 and DualSense now always emit `Wireless Controller` in UHID create events so Steam HID detection stays compatible, while keeping the requested USB/Bluetooth descriptor and report framing unchanged. Tests and fixtures were updated to capture/create-name assertions, and the old effective-profile remap helper/tests were removed.
ReenigneArcher
force-pushed
the
fix/linux/playstation-pads
branch
from
August 16, 2026 01:11
de59e55 to
def6ff0
Compare
Keep the caller-requested DualShock 4 name and USB framing on the Linux UHID backend while still using Sony's native product name for DualSense Steam HID discovery. The tests and platform support docs were updated to assert the DualShock 4 create event and input reports stay on the expected USB path instead of being silently presented as Bluetooth.
ReenigneArcher
force-pushed
the
fix/linux/playstation-pads
branch
from
August 16, 2026 02:06
f1138b3 to
5802929
Compare
Start the UHID reader before sending UHID_CREATE2 and block create() until UHID_START arrives (with timeout and reader-exit failure paths). This keeps control-channel handling active during registration and avoids exposing a gamepad as ready before the kernel HID device has started. Tests and Linux test hooks were updated to script/read UHID_START and assert that create waits for start, and platform docs now describe the new startup behavior.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ReenigneArcher
changed the title
Keep SDL Linux consumer coverage on the evdev path for UHID PlayStation profiles, allowing CI to discover native-named controllers without depending on unavailable hidraw hotplug support. Refactor UHID startup and reader handling and group fixture observations to clear the PR Sonar code smells and duplicated test setup.
Make the event reader const and scope the startup lock through an if initializer, preserving the existing synchronization while clearing the two remaining PR Sonar findings.
Match libvirtualhid UHID devices by their sysfs physical path so SDL HIDAPI can open controllers exposed with Sony's native product name. Restore PS4 and PS5 HIDAPI consumer coverage and grant the same scoped access to their input event nodes.
Document the backend-owned physical path that remains stable when libvirtualhid is linked directly into a host, and recommend it for native-named hidraw and input event nodes.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Expose DS4 and DualSense UHID devices with Sony's native identity while preserving their requested bus, descriptors, and report framing. Start the event reader before registration and wait for UHID_START before reporting successful creation.
Restore nonblocking UHID operation so Steam detects DS4 controllers created at runtime, and add regression coverage for lifecycle synchronization, identity, DS4 USB framing, and open flags.
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage
See our AI usage policy.