fix(linux): assign unique touch tracking IDs on slot reuse - #87
Merged
Conversation
Update the Linux uhid touch backend to emit a new ABS_MT_TRACKING_ID from an incrementing counter whenever a contact is placed in a newly selected slot, instead of reusing the slot index as the tracking ID. This prevents replacement contacts from colliding with active contact identity in evdev consumers. Add pipe-backed touchscreen/trackpad test hooks and a unit test that releases one contact, reuses its slot, and verifies slot selection plus tracking ID sequence (including release -1 and new ID assignment). Also document the slot-reuse and tracking-ID behavior in platform support docs.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #87 +/- ##
==========================================
- Coverage 75.18% 75.17% -0.01%
==========================================
Files 34 34
Lines 8083 8086 +3
Branches 3029 3029
==========================================
+ Hits 6077 6079 +2
+ Misses 1709 1468 -241
- Partials 297 539 +242
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 10 files with indirect coverage changes Continue to review full report in Codecov by Harness.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update the Linux uhid touch backend to emit a new ABS_MT_TRACKING_ID from an incrementing counter whenever a contact is placed in a newly selected slot, instead of reusing the slot index as the tracking ID. This prevents replacement contacts from colliding with active contact identity in evdev consumers.
Add pipe-backed touchscreen/trackpad test hooks and a unit test that releases one contact, reuses its slot, and verifies slot selection plus tracking ID sequence (including release -1 and new ID assignment). Also document the slot-reuse and tracking-ID behavior in platform support docs.
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage
See our AI usage policy.