feat(profile-sync-controller)!: derive auth and user-storage signing keys natively via SIP-6 instead of message-signing-snap - #9824
Open
mathieuartu wants to merge 8 commits into
Open
Conversation
…eys natively via SIP-6 instead of message-signing-snap
mathieuartu
temporarily deployed
to
default-branch
August 11, 2026 13:56 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit fcbe93b. Configure here.
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
montelaidev
changed the title
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 18, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 18, 2026
montelaidev
enabled auto-merge
August 18, 2026 13:57
gantunesr
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
References
Related to: https://consensyssoftware.atlassian.net/browse/MUL-2058
Client test-drive PRs:
Checklist
Note
High Risk
Touches authentication signing and HD seed access via
withKeyringV2Unsafe; any SIP-6 or cache regression could break login or user-storage encryption keys despite parity tests.Overview
BREAKING:
AuthenticationControllerandUserStorageControllerno longer callSnapController:handleRequestforgetPublicKey/signMessage. They derive the same keys in-process via SIP-6 from the HD keyring seed, using new shared helpers (message-signing.ts,hd-keyring-seed.ts) andKeyringController:withKeyringV2Unsafeinstead of snap RPC. Clients must delegate that keyring action and can drop snap-controller wiring for profile sync.Signing behavior is intended to stay byte-identical to
@metamask/message-signing-snap(empty salt). HMAC-SHA-512 for SIP-6 uses @noble/hashes so derivation works on React Native where SubtleCrypto cannot HMAC.auth-snap-requests.tsis removed; snap-related dependencies are dropped in favor of@metamask/key-treeand@noble/curves.AuthenticationControllerscopes its sign-message cache by entropy source (aligned with user storage) so multi-SRP and vault-restore cases do not reuse the wrong signature. Tests and mocks were updated accordingly.Reviewed by Cursor Bugbot for commit b8fe62b. Bugbot is set up for automated code reviews on this repo. Configure here.