feat: auto-enable networks from config-registry - #9879
Draft
mikesposito wants to merge 8 commits into
Draft
Conversation
mikesposito
commented
Aug 14, 2026
Co-authored-by: Michele Esposito <34438276+mikesposito@users.noreply.github.com>
4 tasks
pull Bot
pushed a commit
to dmrazzy/core
that referenced
this pull request
Aug 18, 2026
…ntroller` (MetaMask#9882) ## Explanation <!-- Thanks for your contribution! Take a moment to answer these questions so that reviewers have the information they need to properly understand your changes: * What is the current state of things and why does it need to change? * What is the solution your changes offer and how does it work? * Are there any changes whose purpose might not obvious to those unfamiliar with the domain? * If your primary goal was to update one package but you found you had to update another one along the way, why did you do so? * If you had to upgrade a dependency, why did you do so? --> `BlockTrackerPollingController` is being removed from `@metamask/polling-controller` so that the package doesn't need to depend on `@metamask/network-controller`. The only consumer of the removed class is `@metamask/user-operation-controller`, so it has been moved there (unexported) to leave the consumer unchanged. ## References <!-- Are there any issues that this pull request is tied to? Are there other links that reviewers should consult to understand these changes better? Are there client or consumer pull requests to adopt any breaking changes? For example: * Fixes #12345 * Related to #67890 --> * Related to MetaMask#9879 due to circular dependency ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/processes/updating-changelogs.md) - [ ] I've introduced [breaking changes](https://github.com/MetaMask/core/tree/main/docs/processes/breaking-changes.md) in this PR and have prepared draft pull requests for clients and consumer packages to resolve them <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Breaking public API removal may affect downstream packages; in-repo usage is confined to user-operation-controller with a straight import swap. > > **Overview** > **Breaking:** `@metamask/polling-controller` no longer ships `BlockTrackerPollingController` / `BlockTrackerPollingControllerOnly` and drops its `@metamask/network-controller` dependency (tsconfig and package graph updated accordingly). > > The block-tracker polling mixin now lives inside `@metamask/user-operation-controller` as a local module; `PendingUserOperationTracker` imports it from there instead of from `@metamask/polling-controller`. That implementation pulls shared polling primitives (`AbstractPollingControllerBaseMixin`, `getKey`, and related types) from the polling package’s **new public exports**, so behavior for the sole in-repo consumer should stay the same. > > Docs/changelog and README dependency edges reflect the split; polling-controller eslint suppressions for the removed test file are dropped, and user-operation-controller coverage thresholds are relaxed slightly. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 21b92ae. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
[WIP]:
NetworkControllernow depends onConfigRegistryControllerto auto-enable network configs that have been marked withconfig.isAutoEnabled === true.References
Checklist