feat(kyc-controller): generalize UKYC vendor APIs and add status polling - #9908
Open
georgeweiler wants to merge 3 commits into
Open
feat(kyc-controller): generalize UKYC vendor APIs and add status polling#9908georgeweiler wants to merge 3 commits into
georgeweiler wants to merge 3 commits into
Conversation
Parameterize vendor HTTP and the consents path so KYC stays vendor-neutral, and add refreshKycStatus / statusChanged for user-keyed KYC status. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 3 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 276fd29. Configure here.
…tus polling Stored terms acceptance now records the vendor it was given for, so one vendor's disclaimer ids can no longer satisfy another vendor's flow. `refreshKycStatus` no longer restarts polling when a `reset()` landed mid-request, and `acceptTermsAndStartSession` accepts a zero-argument call again. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fetchDisclaimers/checkKycRequired/createVendorCustomer) so identity vendors share one client surface instead of Iron-branded public methods (createIronCustomer,fetchIronDisclaimers, etc.).initialize({ vendor: 'iron' })→ empty-shell customer → consents → SumSub, skipping MoonPay Check/Auth), plusrefreshKycStatus/statusChangedandgetCustomerIdentity.mainalternative to stacking on #9852; that PR should not merge as-is.Test plan
yarn workspace @metamask/kyc-controller run test(100% coverage)yarn workspace @metamask/kyc-controller run changelog:validateyarn workspace @metamask/kyc-controller run messenger-action-types:checkvendor: 'moonpay'(nocreateIron*on the public surface)initialize({ vendor: 'iron', product: 'money' })andrefreshKycStatusMade with Cursor