[FROM-ML] HID: asus: do not send keyboard init reports to touchpads - #96
Open
NeroReflex wants to merge 1 commit into
Open
[FROM-ML] HID: asus: do not send keyboard init reports to touchpads#96NeroReflex wants to merge 1 commit into
NeroReflex wants to merge 1 commit into
Conversation
pastaq
approved these changes
Aug 20, 2026
pastaq
left a comment
pastaq
left a comment
Member
There was a problem hiding this comment.
Nothing functionally wrong, but IMO the nesting depth is too much and should be reworked for v3.
Member
|
Need a quick rebase, looks good to me though! |
Author
You find me in perfect agreement: https://lore.kernel.org/all/20260819195835.1649657-2-denis.benato@linux.dev/ |
Commit 0919db9 ("HID: asus: always fully initialize devices") added a loop during asus_probe() to send keyboard feature report initializations (asus_kbd_init) to all ASUS HID devices. On ASUS laptops with I2C/HID touchpads (such as the ASUS E200HA), sending keyboard feature reports (FEATURE_KBD_REPORT_ID) to touchpad endpoints sends invalid feature requests to touchpad hardware, corrupting probe state and causing the touchpad to become unresponsive. Wrap the asus_report_id_init loop in an `if (!drvdata->tp)` check so keyboard feature initialization only runs for actual keyboards. Tested on ASUS E200HA (where touchpad functionality is fully restored) and ASUS VivoBook Flip 14 TP401MA (confirming zero regressions). Fixes: 0919db9 ("HID: asus: always fully initialize devices") Cc: stable@vger.kernel.org Signed-off-by: Panz Dev <panz.development@gmail.com>
NeroReflex
force-pushed
the
neroreflex/hid-asus-fix
branch
from
August 20, 2026 15:15
19321d1 to
954238d
Compare
Author
done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sending keyboard initialization packets to touchpads messes them up: I forgot to exclude those devices when I reworked hid-asus and the commit author has sent a fix.
Link v2: https://lore.kernel.org/all/20260818152901.B5D781F00A3D@smtp.kernel.org/
Link v1: https://lore.kernel.org/all/20260818085623.18467-1-panz.development@gmail.com/