Fix keystone clusters not importing and unallocated subgraphs existing - #10272
Open
vaisest wants to merge 1 commit into
Open
Fix keystone clusters not importing and unallocated subgraphs existing#10272vaisest wants to merge 1 commit into
vaisest wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #ninjaComplaint:
Description of the problem being solved:
Previously there was a bug on GGG's side where keystone hashes weren't included in the import. It seems that they still don't import because the code assumes the orbit index to start from 1, which isn't true for keystone clusters.
This also only allows subgraphs to exist if the parent socket is allocated. This fixes some weird UI inconsistencies in pob and on poe.ninja that annoy me
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://poe.ninja/poe1/builds/allflame?items=The+Front+Line
https://poe.ninja/poe1/builds/allflame/character/NotKetsueki-7445/PLEASE_MOMMY?i=1&search=items%3DOne%2BWith%2BNothing Zombie subgraph
Before screenshot:
After screenshot: