Add opt-in Full DPS auto-count for Totem skills - #9849
Open
mcagnion wants to merge 4 commits into
Open
Conversation
mcagnion
marked this pull request as ready for review
May 12, 2026 21:41
mcagnion
force-pushed
the
feature/full-dps-auto-max-totems
branch
from
August 17, 2026 17:47
708ce9d to
fad0bfb
Compare
Add a Configuration option "Auto-count Totems in Full DPS?" that lets Full DPS treat a Totem skill's count as the build's current TotemsSummoned (falling back to ActiveTotemLimit) when the skill's manual Count is 1. Behavior: - Default off: Full DPS uses the manual skill Count, unchanged. - Option on, Count == 1, skill has skillFlags.totem, not Explosive Arrow, and exactly one Totem source is included in Full DPS: Full DPS uses output.TotemsSummoned or output.ActiveTotemLimit. - Option on, Count > 1: manual Count wins. - Explosive Arrow is excluded from scaling because its custom DPS function already accounts for active totems, but it still counts as a Full DPS totem source for the multi-source guard. - Two or more Totem sources included in Full DPS (including Explosive Arrow): auto-count is suppressed and each skill keeps its manual Count, because ActiveTotemLimit is a global slot pool that cannot be allocated automatically across multiple sources. The implementation keeps two predicates intentionally separate: isIncludedFullDPSTotemSource (broader, used by the source counter) matches every included Totem skill that occupies a global totem slot; isFullDPSAutoTotemScalable (narrower, used by the per-skill scaling gate) additionally excludes Explosive Arrow. The option is gated by ifSkillFlag = "totem" so it only appears for builds containing at least one Totem skill, making it useful for comparison tools (Power Report, Compare tab, anoint sorting, trade query) to surface "+1 to maximum number of Summoned Totems" sources in single-totem-source Full DPS setups. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Keep the multi-source regression description clear while satisfying the tracked repository spellcheck.
Count only enabled Full DPS sources, resolve automatic Totem counts in one place, and cover the Explosive Arrow exclusion explicitly.
mcagnion
force-pushed
the
feature/full-dps-auto-max-totems
branch
from
August 22, 2026 07:29
fad0bfb to
c376c5d
Compare
Keep calcFullDPS independent of Totem rules while preserving the existing opt-in behavior behind a private pool-aware policy. Addresses the architecture review for PR 9849.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Power Report, Compare, anoint sorting, trade scoring, and similar comparison tools use Full DPS to evaluate a change. For Totem skills, a source of
+1 to maximum number of Summoned Totemscurrently has no effect on those comparisons unless the user also updates the socket group's manual Count.This PR adds an opt-in Configuration option, Auto-count Totems in Full DPS?. For a single enabled Totem source included in Full DPS at Count 1, it uses the current
TotemsSummonedvalue when available, thenActiveTotemLimit. Manual Count values greater than 1 always win, and the option is off by default.Because
ActiveTotemLimitis a shared slot pool, multiple Totem sources fall back to their manual Counts rather than applying the same global limit to each. Explosive Arrow Ballista still occupies a source slot but is not scaled again because its custom DPS calculation already models active totems. Disabled Vaal variants do not block auto-counting for the remaining active source.Steps taken to verify a working solution:
Build used for the screenshots below:
Example totem build (Hierophant): https://pobb.in/-3AWBE9QE4FU. Any build with a single Totem skill marked Include in Full DPS exhibits the same behavior; builds with multiple included Totem sources keep their manual Counts.
Anoint Item dropdown sorted by Full DPS, option OFF (baseline — "Watchtowers" not in the top 6):
Same Anoint Item dropdown, option ON ("Watchtowers" jumps to #1):
Configuration tab — new option in the Totem section: