Fix possible the encoding argument to Popen is only available on Python 3 in switch.py - #90
Open
begininvoke wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposing a fix for something flagged in
cloudlab/bin/switch.py. It is around line 24.The code uses the
encodingparameter ofsubprocess.Popen, which was introduced in Python 3.6. If the application runs on Python 3.5 or earlier, the call will raise aTypeErrorand abort the SSH subprocess creation, leading to a denial‑of‑service condition for any functionality that depends on this subprocess. Because the failure is immediate and can prevent critical operations, the vulnerability is rated as high.Removed the Python 3.6‑only encoding argument and replaced it with universal_newlines=True, preserving text‑mode I/O while maintaining compatibility with older Python versions.
For reference: rule
python.lang.compatibility.python36.python36-compatibility-Popen2. Rated high.I do not know the codebase, so please check the change fits how the rest of it works. Happy to adjust it or close this if the reasoning is off.
Found with automated scanning (RedGem) and reviewed before opening. If it is not useful, closing it is completely fine.