Grade scan report from alert.action - #1494
Draft
Atakan Solak (mapleleafu) wants to merge 1 commit into
Draft
Conversation
Scan report no longer fetches GET /settings/security-policy. That map stays frozen after Rules & Policies migration, so CI kept grading against stale issueRules. Grade from each alert's resolved action on the full-scan payload instead. Alerts without an action are skipped. Assisted-by: Cursor Grok 4.6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
socket scan reportandsocket scan create --reportnow grade from each alert's resolvedactionon the full-scan payload, instead of re-fetchingGET /v0/orgs/{org}/settings/security-policy.issueRules.actionare skipped (the report stays healthy).scan reportno longer requiressecurity-policy:read.Test plan
socket scan reporton an ATR org still fails/passes the same way as beforesocket scan reporton a migrated R&P org grades against live policy actions, not the frozen security-policy GETsecurity-policy:readcan still runscan reportactiondoes not fail CINote
Cursor Bugbot is generating a summary for commit 0b1076e. Configure here.