Implements Grid.compute_skewness(..., method="equiangle") - #1687
Open
Sevans711 wants to merge 5 commits into
Open
Implements Grid.compute_skewness(..., method="equiangle")#1687Sevans711 wants to merge 5 commits into
Grid.compute_skewness(..., method="equiangle")#1687Sevans711 wants to merge 5 commits into
Conversation
previous implementation wasn't accounting for spherical excess!
also swaps to allowing "method" kwarg as a positional arg. (formula typo was Amin - Areg, but now fixed to Areg - Amin)
Sevans711
marked this pull request as ready for review
August 20, 2026 18:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1686
Overview
Creates
Grid.compute_skewnessand implementsGrid.compute_skewness(..., method="equiangle"). This computes the skewness of all faces based on the equiangle method. See #1686 for more detailed description.Similarly to
Grid.compute_face_node_angles, the result is an xarray.DataArray by default, but can be returned as a UxDataArray if desired, by settingas_uxarray=True.Tiny expansion of scope: clarifies in
_compute_face_node_angles_convexdocstring that the angles there are returned in radians.Expected Usage
PR Checklist
General
Testing & Benchmarking
Documentation
docs/api.rst_)AI Disclosure
AI Usage: GitHub Copilot's inline code suggestions, plus chats with Claude, ChatGPT, Gemini for learning about skewness.