Merge coincident pole and antimeridian nodes in structured grids - #1690
Open
rajeeja wants to merge 2 commits into
Open
Merge coincident pole and antimeridian nodes in structured grids#1690rajeeja wants to merge 2 commits into
rajeeja wants to merge 2 commits into
Conversation
Match nodes in Cartesian space rather than the lon/lat plane so pole and antimeridian nodes are recognized as the same point, and store the resulting polar faces as triangles instead of quads with a repeated corner.
Contributor
Author
|
Checked the docs and user guide for behavior changes: both datasets in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1689
_read_structured_gridmatched nodes in the lon/lat plane, so thenlon+1nodes at each pole and the two sides of the antimeridian were never merged.nlonas expected (36 at 10 deg, 360 at 1 deg) andV - E + F == 2confirms a closed sphere.