Update launch script to handle 26Q4 allowlist logic - #54
Open
mingweiliao wants to merge 1 commit into
Open
Conversation
Also fix the issue that signature is not always the same
tony-mak
approved these changes
Aug 17, 2026
| fi | ||
| # flush-allowlist-changes is not in help page. Use set-temporary-caller as proxy since it is | ||
| # guarded with the same flag | ||
| if $ADB shell cmd app_function help 2>&1 | grep -q "set-temporary-caller"; then |
There was a problem hiding this comment.
Looks good, but it general should we just check if it is 37.2+?
Contributor
Author
There was a problem hiding this comment.
I think checking if the command exist or not is safer in long term since shell command can be updated again in next release unlike API that most certainly would always exist.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the script to handle 26Q4 allowlist logic
Also fix the issue that the signature is not always the same, therefore, the script should fetch it from device