test(io): cover an oss:// round trip against the S3 test endpoint - #893
Open
plusplusjiajia wants to merge 1 commit into
Open
test(io): cover an oss:// round trip against the S3 test endpoint#893plusplusjiajia wants to merge 1 commit into
plusplusjiajia wants to merge 1 commit into
Conversation
Member
|
How about still removing oss support from #889 and then you add it back by adding test and documentation to fileio.md to instruct users how to config for oss? |
Member
Author
@wgtmac Works for me — I'll keep this PR and grow it into that: once #889 lands I'll rebase, restore the scheme, and add |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
oss://support is already on main —ResolveFileIONameroutes it,CanonicalizeS3Schemenormalizes it,IsS3FileIOCredentialPrefixaccepts it — but nothing exercises it against a live endpoint. This adds that evidence rather than asserting it.The test writes, reads back and deletes an object addressed as
oss://, through the path a REST catalog takes: resolution picks the S3 FileIO, and the vended credential — scoped tos3, while the data is addressed asoss://— is matched against the canonicalized location.No new infrastructure: it runs against
ICEBERG_TEST_S3_URI, which in CI is the MinIO the AWS jobs already start, and skips when unset like the other S3 integration tests. The scheme is only a routing label; the connection comes froms3.endpoint