fix(datafusion): surface tag create-time and retention in $tags - #728
Merged
JingsongLi merged 1 commit intoAug 20, 2026
Merged
Conversation
jerry-024
added a commit
to jerry-024/paimon-rust
that referenced
this pull request
Aug 21, 2026
* main: perf: vectorize raw vector search (apache#734) feat(file_index): add predicate evaluation foundation (apache#721) feat(go): add postpone fixed-bucket write bindings (apache#722) perf(vindex): split build timing logs by phase (apache#723) fix(avro): read TIME, BLOB, MULTISET and non-string-key map columns (apache#724) fix(datafusion): surface tag create-time and retention in $tags (apache#728) [core] Support multivalue global index (apache#731) feat: add Java-compatible array predicate pushdown (apache#732) fix: serialize unbounded varchar as string (apache#730) perf(vindex): decouple vector read threads and remove chunk barrier (apache#720) feat(vindex): add DiskANN and IVF-SQ/RQ support (apache#726) # Conflicts: # crates/paimon/src/table/data_file_reader.rs # crates/paimon/src/table/vindex_index_build_builder.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A tag written by Flink or Spark carries
tagCreateTimeandtagTimeRetainednext to the snapshot fields, but
$tagsreported both columns asNULLforevery row.
TagManagerdeserialized the tag file straight intoSnapshot, whichhas no such fields, and nothing rejects unknown keys — so the values on disk were
dropped silently and the table hard-coded two null arrays.
Jackson's shape is easy to get wrong.
JsonSerdeUtilregistersJavaTimeModulewithout disabling
WRITE_DATES_AS_TIMESTAMPS, sotagCreateTimeis the array[year, month, day, hour, minute, second, nanoOfSecond]with trailing zerocomponents omitted — five items is legal — and
tagTimeRetainedis a decimalseconds number, not an ISO string.
pypaimon'stime_utilsencodes exactly thisand states it matches
LocalDateTimeSerializerbyte for byte.Fix:
TagManager::get_with_metadata/list_all_with_metadataparse the twofields alongside the snapshot, padding a short array back to seven components.
Parsing is deliberately lenient: an unexpected shape leaves that one column
NULLrather than failing the query, so a hand-edited tag file cannot break alisting.
$tagsrenders the retention like Java'sDuration.toString().Read side only. Making
sys.create_tagwrite these fields belongs with theprocedure, which #489 is currently changing.