[spark]to DE insert into path,the target table should also be target splits - #9333
Merged
Conversation
weijietong
changed the title
JingsongLi
reviewed
Aug 21, 2026
|
|
||
| val targetReadPlan = | ||
| touchedFileTargetRelation.copy(targetRelation.table, allReadFieldsOnTarget.toSeq) | ||
| touchedFileTargetRelation.copy(output = allReadFieldsOnTarget.toSeq) |
Contributor
There was a problem hiding this comment.
Could you apply the same change to paimon-spark/paimon-spark-4.0/src/main/scala/org/apache/paimon/spark/commands/MergeIntoPaimonDataEvolutionTable.scala? Spark 4.0 compiles its own copy of this class, and its insertActionInvoke still calls touchedFileTargetRelation.copy(targetRelation.table, ...). That replaces the KnownSplitsTable with the original target table, so WHEN NOT MATCHED continues to scan the full target table on Spark 4.0. A regression assertion on the insert-side scan or file count would also prevent the two implementations from drifting again.
Contributor
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
to DE table, the insert path's left anti join could be more efficence by making the target table be target spltis
Tests
minor change, no tests,the existing one cove