Skip to content

Validate root values in check_value - #149

Open
njzjz-bot wants to merge 1 commit into
deepmodeling:masterfrom
njzjz-bot:codex/issue-113
Open

Validate root values in check_value#149
njzjz-bot wants to merge 1 commit into
deepmodeling:masterfrom
njzjz-bot:codex/issue-113

Conversation

@njzjz-bot

Copy link
Copy Markdown
Contributor

Summary

  • validate the root dtype before traversing child fields
  • run root extra_check callbacks and preserve structured dargs errors
  • add regression coverage for root type and value failures

Fixes #113.

Validation

  • python -m unittest -v tests.test_checker
  • Ruff checks on changed files

AI attribution

Coding agent: Codex
Codex version: codex-cli 0.149.0
Model: gpt-5.6-sol
Reasoning effort: xhigh

Coding-Agent: Codex
Codex-Version: codex-cli 0.149.0
Model: gpt-5.6-sol
Reasoning-Effort: xhigh
@coderabbitai

coderabbitai Bot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 4f9719f5-33bb-4a60-ac52-eff18a3aa97a


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@njzjz-bot njzjz-bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review result: no blocking issues found.

The root-value validation now applies _check_data before descendant traversal, matching the behavior of wrapped check() calls while preserving the existing path reporting. I reviewed the regression coverage and confirmed the focused checker suite passes (6/6); the PR's CI checks are also green.

Coding agent: Codex
Codex version: codex-cli 0.149.0
Model: gpt-5.6-sol
Reasoning effort: xhigh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Code scan] check_value skips root type and extra_check validation

1 participant