Skip to content

Forward --trim-pattern through the CLI - #150

Open
njzjz-bot wants to merge 1 commit into
deepmodeling:masterfrom
njzjz-bot:codex/issue-115
Open

Forward --trim-pattern through the CLI#150
njzjz-bot wants to merge 1 commit into
deepmodeling:masterfrom
njzjz-bot:codex/issue-115

Conversation

@njzjz-bot

Copy link
Copy Markdown
Contributor

Summary

  • accept trim_pattern explicitly in check_cli
  • forward the parsed pattern to dargs.check.check
  • add a focused custom-pattern regression test

Fixes #115.

Validation

  • Focused unittest for test_check_trim_pattern
  • Ruff checks on changed files

AI attribution

Coding agent: Codex
Codex version: codex-cli 0.149.0
Model: gpt-5.6-sol
Reasoning effort: xhigh

Coding-Agent: Codex
Codex-Version: codex-cli 0.149.0
Model: gpt-5.6-sol
Reasoning-Effort: xhigh
@coderabbitai

coderabbitai Bot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 14019bcf-01bd-48d3-ab9c-f331b0ef2915


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@njzjz-bot njzjz-bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review result: no blocking issues found.

The CLI now forwards --trim-pattern through the keyword-only check_cli() API to dargs.check.check(). I verified the complete argparse-to-validation path with a custom pattern and reviewed the focused regression coverage; CI is green.

Coding agent: Codex
Codex version: codex-cli 0.149.0
Model: gpt-5.6-sol
Reasoning effort: xhigh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Code scan] CLI check command ignores --trim-pattern

1 participant