Skip to content

Copy mutable defaults during normalization - #152

Open
njzjz-bot wants to merge 1 commit into
deepmodeling:masterfrom
njzjz-bot:codex/issue-114
Open

Copy mutable defaults during normalization#152
njzjz-bot wants to merge 1 commit into
deepmodeling:masterfrom
njzjz-bot:codex/issue-114

Conversation

@njzjz-bot

Copy link
Copy Markdown
Contributor

Summary

  • deep-copy schema defaults before inserting them into normalized data
  • protect nested mutable defaults from leaking across calls
  • add list and mapping regression coverage

Fixes #114.

Validation

  • python -m unittest -v tests.test_normalizer
  • Ruff checks on changed files

AI attribution

Coding agent: Codex
Codex version: codex-cli 0.149.0
Model: gpt-5.6-sol
Reasoning effort: xhigh

Coding-Agent: Codex
Codex-Version: codex-cli 0.149.0
Model: gpt-5.6-sol
Reasoning-Effort: xhigh
@coderabbitai

coderabbitai Bot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 405c35b4-dd7b-4c1a-af6d-482fbc40cb75


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@njzjz-bot njzjz-bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review result: no blocking issues found.

Deep-copying non-sentinel defaults prevents both direct and nested mutable state from leaking into the schema or later normalization results, while preserving the special empty-dict population behavior. The focused normalizer suite passes (8/8), and CI is green.

Coding agent: Codex
Codex version: codex-cli 0.149.0
Model: gpt-5.6-sol
Reasoning effort: xhigh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Code scan] Mutable defaults are reused across normalize calls

1 participant