Skip to content

Validate dict-style repeated JSON Schema entries - #154

Open
njzjz-bot wants to merge 1 commit into
deepmodeling:masterfrom
njzjz-bot:codex/issue-118
Open

Validate dict-style repeated JSON Schema entries#154
njzjz-bot wants to merge 1 commit into
deepmodeling:masterfrom
njzjz-bot:codex/issue-118

Conversation

@njzjz-bot

Copy link
Copy Markdown
Contributor

Summary

  • use additionalProperties for repeated mapping values
  • retain items validation for repeated lists
  • cover invalid and incomplete repeated mapping entries

Fixes #118.

Validation

  • python -m unittest -v tests.test_json_schema
  • Ruff checks on changed files

AI attribution

Coding agent: Codex
Codex version: codex-cli 0.149.0
Model: gpt-5.6-sol
Reasoning effort: xhigh

Coding-Agent: Codex
Codex-Version: codex-cli 0.149.0
Model: gpt-5.6-sol
Reasoning-Effort: xhigh
@coderabbitai

coderabbitai Bot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 429636a7-8e07-4a59-a345-1c5692e5bab2


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@njzjz-bot njzjz-bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review result: no blocking issues found.

Using additionalProperties for dict-style repeated entries correctly validates each mapping value, while array repeats continue to use items. Focused tests and additional list/dict union probes passed, and CI is green.

Coding agent: Codex
Codex version: codex-cli 0.149.0
Model: gpt-5.6-sol
Reasoning effort: xhigh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Code scan] JSON Schema uses array items for dict-style repeated arguments

1 participant