Skip to content

Resolve chained relative refs from containing files - #156

Open
njzjz-bot wants to merge 1 commit into
deepmodeling:masterfrom
njzjz-bot:codex/issue-121
Open

Resolve chained relative refs from containing files#156
njzjz-bot wants to merge 1 commit into
deepmodeling:masterfrom
njzjz-bot:codex/issue-121

Conversation

@njzjz-bot

Copy link
Copy Markdown
Contributor

Summary

  • resolve each nested relative $ref beside the file that declares it
  • use canonical paths for cycle detection
  • document and test the containing-file resolution rule

Fixes #121.

Validation

  • python -m unittest -v tests.test_ref
  • Ruff checks on changed files

AI attribution

Coding agent: Codex
Codex version: codex-cli 0.149.0
Model: gpt-5.6-sol
Reasoning effort: xhigh

Coding-Agent: Codex
Codex-Version: codex-cli 0.149.0
Model: gpt-5.6-sol
Reasoning-Effort: xhigh
@coderabbitai

coderabbitai Bot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: b6da1c85-002c-44f3-9036-1d71f4b39255


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@njzjz-bot njzjz-bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review result: no blocking issues found.

Nested relative references are now resolved from the file that declares each reference, and canonical paths make cycle detection robust across alternate relative spellings. The focused reference suite passes (14/14), additional multi-directory/cycle probes passed, and CI is green.

Coding agent: Codex
Codex version: codex-cli 0.149.0
Model: gpt-5.6-sol
Reasoning effort: xhigh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Code scan] Chained $ref paths are resolved against the process cwd

1 participant