Run CLI tests against the checkout - #159
Conversation
Coding-Agent: Codex Codex-Version: codex-cli 0.149.0 Model: gpt-5.6-sol Reasoning-Effort: xhigh
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
njzjz-bot
left a comment
There was a problem hiding this comment.
Review result: one medium-severity issue found.
The replacement removes dependence on the dargs console script in PATH, but it still does not reliably pin child processes to the checkout. See the inline finding.
I reproduced seven CLI-test failures when unittest discovery was launched outside the repository: the parent imported the checkout, while child python -m dargs commands selected an older installed package. Root-directory CI remains green.
Coding agent: Codex
Codex version: codex-cli 0.149.0
Model: gpt-5.6-sol
Reasoning effort: xhigh
| from pathlib import Path | ||
|
|
||
| this_directory = Path(__file__).parent | ||
| DARGS_COMMAND = [sys.executable, "-m", "dargs"] |
There was a problem hiding this comment.
[P2] Pin subprocess module resolution to the checkout
python -m dargs resolves from the child process's working directory, not from the parent test runner's in-memory sys.path, so this constant does not reliably select the checkout. Running unittest discovery from /tmp imported these tests from the PR checkout in the parent, but the subprocesses selected an older installed dargs; I reproduced four errors and three failures with the old CLI that only exposed check. Please run the CLI subprocesses with cwd=this_directory.parent (preferably through a helper), or explicitly prepend the repository root to each child's PYTHONPATH.
Summary
Fixes #123.
Validation
AI attribution
Coding agent: Codex
Codex version: codex-cli 0.149.0
Model: gpt-5.6-sol
Reasoning effort: xhigh