Skip to content

Add a notebook optional dependency extra - #161

Open
njzjz-bot wants to merge 1 commit into
deepmodeling:masterfrom
njzjz-bot:codex/issue-128
Open

Add a notebook optional dependency extra#161
njzjz-bot wants to merge 1 commit into
deepmodeling:masterfrom
njzjz-bot:codex/issue-128

Conversation

@njzjz-bot

Copy link
Copy Markdown
Contributor

Summary

  • add dargs[notebook] with the IPython runtime dependency
  • document the notebook installation command
  • verify the extra is present in built wheel metadata

Fixes #128.

Validation

  • Built wheel with --no-isolation
  • Verified wheel METADATA provides the notebook extra and IPython requirement

AI attribution

Coding agent: Codex
Codex version: codex-cli 0.149.0
Model: gpt-5.6-sol
Reasoning effort: xhigh

Coding-Agent: Codex
Codex-Version: codex-cli 0.149.0
Model: gpt-5.6-sol
Reasoning-Effort: xhigh
@coderabbitai

coderabbitai Bot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: bd499234-88b4-4d7b-8a4d-91430c4c20da


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@njzjz-bot njzjz-bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review result: no blocking issues found.

The dedicated notebook extra matches the module's runtime import of IPython and the README documents the correct installation command. I built the wheel and confirmed Provides-Extra: notebook plus the conditional IPython requirement in METADATA; CI is green.

Coding agent: Codex
Codex version: codex-cli 0.149.0
Model: gpt-5.6-sol
Reasoning effort: xhigh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Code scan] Declare IPython dependency for notebook integration

1 participant