chore(deps): batch trivial dependency updates - #474
Conversation
Applies 14 dependency updates from open Renovate PRs that require no substantive source changes. Runtime dependencies: - reflect-metadata ^0.1.12 -> ^0.2.0 (#284) - flatted 3.4.2 -> 3.4.4 (#457) - @lumino/widgets ^2.4.0 -> ^2.9.0 (#329) - re-resizable ^6.5.5 -> ^6.11.2 (#282) Dev dependencies: - @actions/glob ^0.5.1 -> ^0.7.0 (#289) - @vscode/test-cli ^0.0.8 -> ^0.0.15 (#289) - @vscode/test-web ^0.0.71 -> ^0.0.81 (#289) - cspell 9.2.1 -> 9.8.0 (#289) - lint-staged 16.2.3 -> 16.4.0 (#289) - source-map ^0.7.4 -> ^0.8.0 (#289) - @types/pdfkit ^0.11.0 -> ^0.17.0 (#288) - @types/react-json-tree ^0.6.8 -> ^0.13.0 (#288) - @types/stack-trace 0.0.29 -> 0.0.33 (#288) - @types/temp ^0.8.32 -> ^0.9.0 (#288) Supporting changes: - Pin mocha to 11.0.1. @vscode/test-cli 0.0.15 requires mocha ^11.7.6, which pulled the hoisted root mocha to 11.8.0; that version loads the --require bootstrap (out/test/unittests.js) as ESM and the whole unit suite fails with "require is not defined in ES module scope". Pinning keeps mocha at 11.0.1 at the root while test-cli resolves its own nested copy. - Bump the @cspell/dict-en-common-misspellings license-checker exclusion from 2.1.6 to 2.2.0 to match the version cspell 9.8.0 resolves. - Drop a now-unnecessary @ts-expect-error in plotViewer.node.ts; @types/pdfkit 0.17 ships declarations for pdfkit/js/pdfkit.standalone. Verification: typecheck, lint, format, spell-check, license-check, esbuild bundle, and unit tests (2762 passing) all green. npm install is idempotent against the lockfile, so the drift check passes. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SLK3q2h5EwTC9hFs1bEwLJ
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
Included review availability: 3 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 4 reviews per hour. 📝 WalkthroughWalkthroughThe change updates runtime, development-tool, type-package, license-exclusion, and override versions in Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This PR batches dependency and lockfile updates with supporting metadata cleanup, and the reported validation checks pass; no actionable merge-blocking risk remains beyond normal review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #474 +/- ##
===========================
===========================
🚀 New features to boost your workflow:
|
Brings in the ESLint -> oxlint migration (#468). Conflict was limited to package-lock.json. Resolved by taking main's lockfile as the base and re-resolving against the merged package.json, rather than merging lock entries, so the oxlint migration's resolutions are preserved exactly and only the batched dependency bumps re-resolve. All 15 dependency changes from this branch survived the merge; typescript and @types/node are unchanged from main. Verification on the merged tree: typecheck, oxlint, format, spell-check, license-check, production audit, esbuild bundle, and unit tests (2762 passing) all green. npm install is idempotent against the lockfile. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SLK3q2h5EwTC9hFs1bEwLJ
|
Merged
How the lockfile conflict was resolved: rather than merging lock entries, I took All 15 dependency changes survived the merge ( The lockfile also shows 131 removals vs Re-verified on the merged tree (note:
For the record, all 12 CI checks were green on the pre-merge commit ( |
|
@coderabbitai full review |
✅ Action performedFull review finished. |
Summary
Batch-applies the Renovate dependency updates that need no substantive source
changes, verified locally against the full CI suite. Each update was triaged
individually rather than per-PR, so mixed group PRs are split.
Included updates
reflect-metadata^0.1.12→^0.2.0flatted3.4.2→3.4.4@lumino/widgets^2.4.0→^2.9.0re-resizable^6.5.5→^6.11.2@actions/glob^0.5.1→^0.7.0@vscode/test-cli^0.0.8→^0.0.15@vscode/test-web^0.0.71→^0.0.81cspell9.2.1→9.8.0lint-staged16.2.3→16.4.0source-map^0.7.4→^0.8.0@types/pdfkit^0.11.0→^0.17.0@types/react-json-tree^0.6.8→^0.13.0@types/stack-trace0.0.29→0.0.33@types/temp^0.8.32→^0.9.0Supporting changes
mochapinned to11.0.1(was^11.0.1).@vscode/test-cli0.0.15requires
mocha ^11.7.6, which pulled the hoisted rootmochaup to11.8.0. That version loads the
--requirebootstrap (out/test/unittests.js)as ESM, and the entire unit suite dies with
ReferenceError: require is not defined in ES module scope. Pinning keepsthe root at 11.0.1 while
@vscode/test-cliresolves its own nested copy.Adapting the bootstrap to mocha 11.8 is real source work and belongs in its
own PR.
@cspell/dict-en-common-misspellings@2.1.6to@2.2.0. The exclusion isversion-pinned, and cspell 9.8.0 resolves the newer dictionary (same
non-SPDX license as before), so
check-licensesfails without this.@ts-expect-errorinplotViewer.node.ts.@types/pdfkit0.17 now ships declarations forpdfkit/js/pdfkit.standalone, so the directive became unused and trippednoUnusedTsExpectError.Skipped (left for follow-up)
glob^9.3.5→^10import glob from 'glob', and v10 has no default export (TS2613), plus callback→promise API changes. Security PR — worth a dedicated fix.react-svgmt1.1.11→1.2.0ERESOLVE: peerreact@^17, repo is onreact@16.14.0. Blocked on a React major.@nteract/transform-vega→7.0.10@blueprintjs/core3.54 and friends; both audit jobs fail..nvmrc)@types/*remainder of the DefinitelyTyped groupVerification
Run locally in a worktree on Node 22.21.1 / npm 10.9.4:
tsc -p ./npm run lintnpm run formatnpm run spell-checknpm run check-licensesnpm audit --omit=devnpx tsx build/esbuild/build.tsnpm run test:unittestsnpm installidempotency (drift check)npm audit(including dev) still reports the same 5 low-severityellipticfindings as
main; those resolutions are byte-identical tomainand are notintroduced here.
Lockfile note
The lockfile was rebased on
mainand re-resolved only for the targeteddependencies, rather than blanket-regenerated. A full re-resolution drifted 309
transitive packages — including
typescript5.8.3 → 5.9.3, which introduced 4typecheck errors. This PR keeps
typescriptand@types/nodeunchanged.After merge
#284, #457, #329, and #282 are fully included and can be closed. #288 and #289
were partially included and will shrink when Renovate rebases them.
🤖 Generated with Claude Code
https://claude.ai/code/session_01SLK3q2h5EwTC9hFs1bEwLJ
Summary by CodeRabbit