feat(scope): add missing public mutators - #2011
Open
jpnurmi wants to merge 2 commits into
Open
Conversation
Add scope-specific release, environment, and transaction setters plus tag, extra, context, and attachment removals. Route the corresponding global APIs through the new functions. This makes reusable scope mutation more symmetric with the global scope API. Console SDKs currently update some of these fields through private scope access, coupling them to internals and making scope refactors (RW-locks) harder than it needs to be. :)
|
mujacica
approved these changes
Aug 21, 2026
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #2011 +/- ##
==========================================
+ Coverage 74.69% 74.73% +0.03%
==========================================
Files 104 104
Lines 26182 26223 +41
Branches 4740 4743 +3
==========================================
+ Hits 19557 19597 +40
+ Misses 5295 5294 -1
- Partials 1330 1332 +2 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the scope API more symmetric with the global scope and scope observer APIs by adding the following missing scope-level mutators:
set_release,set_environment,set_transaction,remove_tag,remove_extra,remove_context, andremove_attachment.Console SDKs currently update some of these fields through direct private
sentry_scope_saccess, coupling them with internal implementation details, and making scope refactoring (RW-locks) harder than it needs to be. :)