[rig-claude] Improve Claude dynamic-workflow compatibility for rig - #428
Merged
Merged
Conversation
The code snippet in the 'Running with the Anthropic engine' section used
call and text without importing or defining them, making the example
non-runnable and misleading to users porting Claude dynamic workflows.
Replace the bare top-level await call() with a complete, self-contained
workflow({ body: async ({ call, input }) }) that demonstrates the correct
per-call model override pattern inside a workflow body.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
pelikhan
approved these changes
Aug 15, 2026
pelikhan
marked this pull request as ready for review
August 15, 2026 13:19
Contributor
Author
|
🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅ |
Contributor
Author
There was a problem hiding this comment.
Skills-Based Review 🧠
Applied /codebase-design — approving. The fix is correct and well-scoped.
📋 Summary
What was fixed
The broken await call(classifier, { text }, { model: ... }) snippet (where call and text were undefined) is replaced with a complete, self-contained workflow({ ... body: async ({ call, input }) => ... }) that compiles correctly and matches the idiomatic rig pattern.
Positive highlights
- ✅ The fix is minimal and surgical — only the broken code block is changed
- ✅ The replacement uses the correct idiomatic pattern (
calldestructured from body,input.textfor the typed field) - ✅ The pedagogical point (per-call
modeloverride) is preserved - ✅ PR description accurately describes the problem and the fix
No blocking issues found.
🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · sonnet46 14.5 AIC · ⌖ 4.08 AIC · ⊞ 6.3K
Comment /matt to run again
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compatibility gap addressed
The Anthropic engine example in
skills/rig/references/claude-workflow-conversion.mdcontained a broken code snippet:callandtextwere never imported or defined, making the example fail at a glance and misleading anyone trying to port a Claude dynamic workflow that uses per-call model overrides (a common pattern:agent(prompt, { model: "claude-opus-4-5" })).Why this improves transfer from Claude dynamic workflows to Rig
Per-call model selection (
{ model: "..." }) is listed in the primitive mapping table as a 1-to-1 correspondence, but the only runnable example was broken. A Claude dynamic-workflow author who lands on this section expecting to understand how to swap models would see an immediately non-compiling snippet.The fix replaces the bare
await call(...)with a completeworkflow({ body: async ({ call, input }) => ... })that:modeloverride)Files changed
skills/rig/references/claude-workflow-conversion.md— Fixed the broken Anthropic model override example to be a complete, self-contained workflowValidation run
Only a documentation file changed; no code or tests were modified. Per the task's validation rules, no build/test command is required for docs-only changes. Links in the file were verified to be unchanged.
Remaining intentional differences
None introduced by this change. The existing behavioral differences section in the doc remains accurate.