feat(output): auto-right-align numeric columns in the no-view fallback path - #96
Merged
Conversation
…k path A command with no registered view renders through the dynamic column catalog (dynamic_columns), which always built Alignment::Left columns with no way to opt into right-alignment the way a registered view's TableColumn::align can. Detects a field that's a JSON number on every row it appears in (nulls/missing don't disqualify it, but any other type anywhere does) and right-aligns that column automatically. Registered views are unaffected: they still default to Alignment::Left and must opt in explicitly, since a numeric-looking field there (an ID, say) may not be a real measurement. Fixes DEVEX-1020 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
qcai-godaddy
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
render_array: a field that's a JSON number on every row it appears in (nulls/missing don't disqualify it, but any other value type anywhere does) now renders right-aligned automatically, matching what a registered view gets fromTableColumn::align(Alignment::Right)(feat(output): add TableColumn::align for right-aligned table columns #94).Alignment::Leftand must opt in explicitly, since a view author may have a numeric-looking column (an opaque ID, say) that shouldn't be right-aligned.docs/concepts.md.Fixes DEVEX-1020
Test plan
cargo fmt --all --checkcargo clippy --all-targets -- -D warningscargo test --all-targetsRUSTDOCFLAGS='-D warnings' cargo doc --no-depstests/exhaustive_output.rsreproducing this end-to-end with no registered view🤖 Generated with Claude Code