Reorganize core's export surface into audience-specific subpaths - #169
Merged
Conversation
Split packages/core's flat index.ts into root plus ./did, ./wire and ./adapter subpaths so a caller's import path signals audience: apps at keygen/custody, both sides of the auth handshake, and adapter implementers, respectively. Root no longer re-exports the subpaths. Also removes the 20 runtime exports and 3 types with no reference outside packages/core per the un-export audit, keeping the 8 that have a named consumer with a comment pointing to it. Updates every in-repo consumer, their vitest subpath aliases, and the READMEs/spec docs that showed import examples. Refs #168
access.ts loses its singled-out "internal — no public export" note — id.ts, schema.ts, did.ts, auth.ts and attachment-download.ts are just as implementation-only and weren't annotated either. testing.ts now says explicitly that it's exported, since it (unlike those files) is the public /testing surface itself, not an implementation detail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split packages/core's flat index.ts into root plus ./did, ./wire and
./adapter subpaths so a caller's import path signals audience: apps at
keygen/custody, both sides of the auth handshake, and adapter
implementers, respectively. Root no longer re-exports the subpaths.
Also removes the 20 runtime exports and 3 types with no reference
outside packages/core per the un-export audit, keeping the 8 that have
a named consumer with a comment pointing to it. Updates every in-repo
consumer, their vitest subpath aliases, and the READMEs/spec docs that
showed import examples.
Closes #168