Bump major-version dependencies (hono/node-server, eslint, pino, vitest, @types/node) - #66
Merged
Merged
Conversation
…st, @types/node The previous dependency PR (#65) intentionally left six available major bumps alone. This picks those up, one at a time, verifying typecheck/ lint/format/test plus a real end-to-end smoke test (actual serve() process, real HTTP requests, graceful shutdown) after each: - @hono/node-server 1 -> 2 - eslint 9 -> 10 (also clears the pre-existing @eslint/js peer warning, since @eslint/js was already on ^10.0.0) - pino 9 -> 10 (verified pino-pretty's dev transport still works) - vitest 2 -> 4 (needed `vite` added explicitly as a devDependency — vitest 4 requires vite ^6/^7/^8 as a peer, and nothing in the tree was pulling a compatible version in on its own) - @types/node 22 -> 26 typescript 5 -> 7 was left alone: typescript-eslint 8.67.0 (its latest release) hard-refuses to run under TS 7 ("typescript-eslint does not support TS 7.0"), and its own peer range caps at <6.1.0. There's no newer typescript-eslint release yet — see typescript-eslint/typescript-eslint#10940 for upstream tracking. Revisit once that lands. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QejGigAtq61ZKuwq3738t2
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #65, which intentionally left six available major bumps alone. This PR picks up five of them, each verified independently with typecheck/lint/format/test plus a real end-to-end smoke test (an actual
serve()process, real HTTP requests against/.well-known/stackandPOST /records, and graceful shutdown) — not just the mocked-transport test suite:@hono/node-servereslintpinovitest@types/nodeeslint9→10 also clears a peer-dependency warning that predates this PR:@eslint/jswas already pinned to^10.0.0whileeslintitself was still on^9.0.0.vitest2→4 neededviteadded as an explicit devDependency (^8.2.1) — vitest 4 requires vite^6 || ^7 || ^8as a peer, and nothing already in the tree was pulling a compatible version in on its own. Without it, the suite failed to even start (ERR_PACKAGE_PATH_NOT_EXPORTEDon vite's./module-runnersubpath).pino9→10: verified the dev-modepino-prettytransport still works, not just that the package resolves — ran the real entrypoint and confirmed colorized output and clean shutdown.@hono/node-server1→2: same treatment — ran the real server and hit it with actual HTTP requests, since the test suite only ever callsapp.request()directly and never exercisesserve().Left alone
typescript5→7 is not upgraded.typescript-eslint8.67.0 (its current latest release) hard-refuses to run under TypeScript 7 —pnpm lintfails immediately with:and its own peer range caps at
typescript@">=4.8.4 <6.1.0". There's no newertypescript-eslintrelease yet; upstream is tracking support at typescript-eslint#10940.tsc --noEmitalone was fine under TS 7 — it's specifically the lint toolchain that blocks this one. Worth revisiting once that lands.Test plan
pnpm typecheckpnpm lintpnpm format:checkpnpm buildpnpm test— 215/215 passingserve()process,GET /.well-known/stackandPOST /recordsover real HTTP,pino-prettydev transport, graceful SIGTERM shutdownGenerated by Claude Code