Skip to content

test: Fix the modarith benchmarks measuring dead code #1663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chfast merged 1 commit into from
Aug 19, 2026
+8 −0
Merged

test: Fix the modarith benchmarks measuring dead code #1663

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions test/internal_benchmarks/modarith_bench.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ namespace
constexpr auto bn254 = 0x30644e72e131a029b85045b68181585d97816a916871ca8d3c208c16d87cfd47_u256;
constexpr auto secp256k1 = 0xfffffffffffffffffffffffffffffffffffffffffffffffffffffffefffffc2f_u256;

// Each pair of operations forms a single dependency chain, so the reported time is the latency.

template <typename UintT, const UintT& Mod>
void modarith_add(benchmark::State& state)
{
Expand All @@ -24,6 +26,8 @@ void modarith_add(benchmark::State& state)
a = m.add(a, b);
b = m.add(b, a);
}
benchmark::DoNotOptimize(a);
benchmark::DoNotOptimize(b);
}

template <typename UintT, const UintT& Mod>
Expand All @@ -38,6 +42,8 @@ void modarith_sub(benchmark::State& state)
a = m.sub(a, b);
b = m.sub(b, a);
}
benchmark::DoNotOptimize(a);
benchmark::DoNotOptimize(b);
}

template <typename UintT, const UintT& Mod>
Expand All @@ -52,6 +58,8 @@ void modarith_mul(benchmark::State& state)
a = m.mul(a, b);
b = m.mul(b, a);
}
benchmark::DoNotOptimize(a);
benchmark::DoNotOptimize(b);
}
} // namespace

Expand Down