#777 test pam_interactive (including multistep capability) automatically - #824
Conversation
|
Test of multistep doesn't yet pass, even when iRODS4j is run, so something is probably wrong with the test setup. Awaiting a branch of irods/irods4j in which ports are exposed to test PRC on a valid setup |
|
Is the PAM Interactive test run expected to fail in GitHub Actions? See the following: |
No, it should pass ... looking |
I can only get it to pass by reverting our change (702f723) to the native handoff from pam_interactive to the native auth phase. If I do that, all tests related to pam_interactive (including my new tests in test012...) pass once again. Not sure how this should look, for the moment. Will need to study. |
|
That's fine. Those changes do not need to be part of this PR. Keep them in a separate branch so that we can investigate them later. |
238268a to
4ddccfc
Compare
|
Waiting for tests to pass. As soon as they do, let's go with a final review. |
c14719e to
66e67e6
Compare
|
TODOs have been moved to another dev branch, issues will be created for those. Other troubleshooting related changes that resulted in dead ends have also been removed. |
korydraughn
left a comment
There was a problem hiding this comment.
Looks like this is ready for squashing?
I'd say so. Will squash soon. |
|
Squashed but then adding a commit to ensure conditions are right for both test methods in |
|
Final squash done. |
korydraughn
left a comment
There was a problem hiding this comment.
Pound it.
Don't forget to remove the [SQUASH] text from the commit message.
|
Pounded |
|
Will merge after github actions reports success. |
No description provided.