Skip to content

#777 test pam_interactive (including multistep capability) automatically - #824

Merged
korydraughn merged 1 commit into
irods:mainfrom
d-w-moore:777.m
Aug 19, 2026
Merged

#777 test pam_interactive (including multistep capability) automatically#824
korydraughn merged 1 commit into
irods:mainfrom
d-w-moore:777.m

Conversation

@d-w-moore

Copy link
Copy Markdown
Collaborator

No description provided.

@d-w-moore

Copy link
Copy Markdown
Collaborator Author

Test of multistep doesn't yet pass, even when iRODS4j is run, so something is probably wrong with the test setup. Awaiting a branch of irods/irods4j in which ports are exposed to test PRC on a valid setup

@korydraughn

korydraughn commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Is the PAM Interactive test run expected to fail in GitHub Actions? See the following:

@d-w-moore

Copy link
Copy Markdown
Collaborator Author

Is the PAM Interactive test run expected to fail in GitHub Actions? See the following:

* https://github.com/irods/python-irodsclient/actions/runs/31617526699/job/94183959927?pr=824

No, it should pass ... looking

@d-w-moore

Copy link
Copy Markdown
Collaborator Author

Is the PAM Interactive test run expected to fail in GitHub Actions? See the following:

* https://github.com/irods/python-irodsclient/actions/runs/31617526699/job/94183959927?pr=824

No, it should pass ... looking

I can only get it to pass by reverting our change (702f723) to the native handoff from pam_interactive to the native auth phase. If I do that, all tests related to pam_interactive (including my new tests in test012...) pass once again.

Not sure how this should look, for the moment. Will need to study.

@korydraughn

Copy link
Copy Markdown
Contributor

That's fine. Those changes do not need to be part of this PR. Keep them in a separate branch so that we can investigate them later.

@d-w-moore
d-w-moore force-pushed the 777.m branch 5 times, most recently from 238268a to 4ddccfc Compare August 14, 2026 09:59
@d-w-moore

Copy link
Copy Markdown
Collaborator Author

Waiting for tests to pass. As soon as they do, let's go with a final review.

@d-w-moore
d-w-moore force-pushed the 777.m branch 2 times, most recently from c14719e to 66e67e6 Compare August 17, 2026 14:27
@d-w-moore

Copy link
Copy Markdown
Collaborator Author

TODOs have been moved to another dev branch, issues will be created for those. Other troubleshooting related changes that resulted in dead ends have also been removed.

Comment thread dummy Outdated
Comment thread irods/auth/pam_interactive.py Outdated

@korydraughn korydraughn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is ready for squashing?

@d-w-moore

Copy link
Copy Markdown
Collaborator Author

Looks like this is ready for squashing?

I'd say so. Will squash soon.

@d-w-moore

d-w-moore commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator Author

Squashed but then adding a commit to ensure conditions are right for both test methods in test012_pam_interactive_multistep.bats , in other words .irodsA is not present as an initial condition for each test.

@korydraughn korydraughn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squash it.

@d-w-moore

Copy link
Copy Markdown
Collaborator Author

Final squash done.

@korydraughn korydraughn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pound it.

Don't forget to remove the [SQUASH] text from the commit message.

@d-w-moore

Copy link
Copy Markdown
Collaborator Author

Pounded

@korydraughn

Copy link
Copy Markdown
Contributor

Will merge after github actions reports success.

@korydraughn
korydraughn merged commit d3cbda0 into irods:main Aug 19, 2026
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants