Clearer error message with constrained variables in VectorOfVariables - #3061
Open
blegat wants to merge 2 commits into
Open
Clearer error message with constrained variables in VectorOfVariables#3061blegat wants to merge 2 commits into
blegat wants to merge 2 commits into
Conversation
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When there was a variable constrained at creation in a
VectorOfVariablesconstraint, it was just throwing aMethodError. Now we have a clearer error.The reason we error is that we want to keep the
VectorOfVariablestype. If a variable is mapped to a variable, we can actually make it work. It is useful for https://github.com/NexOR-Optimization/MathOptVRP.jl/blob/0fc70cc2176767472aad8643c2e2c8f66e5cd00e/src/Bridges/PermutationToPartitionBridge.jl#L17 which mapped variables to other variables without transformation.Also for
MathOptInterface.jl/src/Bridges/Variable/bridges/VectorizeBridge.jl
Line 37 in 9bddcb7