Skip to content

Fix CMake generator expression - #30

Merged
David-LP99 merged 1 commit into
kiltedfrom
Narukara-patch-1
Aug 20, 2026
Merged

Fix CMake generator expression#30
David-LP99 merged 1 commit into
kiltedfrom
Narukara-patch-1

Conversation

@Narukara

@Narukara Narukara commented Aug 19, 2026

Copy link
Copy Markdown

When building the kilted branch of micro-ROS/micro_ros_espidf_component, I get the following error:

--- stderr: rcl
CMake Error at CMakeLists.txt:88 (add_library):
  Target "rcl" links to target
  "$<0:rcl_interfaces::rcl_interfaces__rosidl_generator_c" but the target was
  not found.  Perhaps a find_package() call is missing for an IMPORTED
  target, or an ALIAS target is missing?


CMake Error at CMakeLists.txt:88 (add_library):
  Target "rcl" links to target
  "rcl_interfaces::rcl_interfaces__rosidl_typesupport_c>" but the target was
  not found.  Perhaps a find_package() call is missing for an IMPORTED
  target, or an ALIAS target is missing?


CMake Generate step failed.  Build files cannot be regenerated correctly.

This appears to be caused by unquoted generator expressions being split at semicolons. This issue only seems to occur with older versions of CMake. I'm using CMake 3.22.1.

Local testing confirms that the project builds successfully after the generator expressions are quoted.

@mergify

mergify Bot commented Aug 19, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@David-LP99
David-LP99 merged commit ec6ff30 into kilted Aug 20, 2026
3 checks passed
@David-LP99

Copy link
Copy Markdown

@mergify backport rolling lyrical

@mergify

mergify Bot commented Aug 20, 2026

Copy link
Copy Markdown

backport rolling lyrical

✅ Backports have been created

Details

Cherry-pick of dc07301 has failed:

On branch mergify/bp/rolling/pr-30
Your branch is up to date with 'origin/rolling'.

You are currently cherry-picking commit dc07301.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   rcl/CMakeLists.txt

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Cherry-pick of dc07301 has failed:

On branch mergify/bp/lyrical/pr-30
Your branch is up to date with 'origin/lyrical'.

You are currently cherry-picking commit dc07301.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   rcl/CMakeLists.txt

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants