Skip to content

fix(server): deregister terminated streamable HTTP sessions - #3302

Open
mikemikimike wants to merge 4 commits into
modelcontextprotocol:mainfrom
mikemikimike:codex/3300-session-deregister
Open

fix(server): deregister terminated streamable HTTP sessions#3302
mikemikimike wants to merge 4 commits into
modelcontextprotocol:mainfrom
mikemikimike:codex/3300-session-deregister

Conversation

@mikemikimike

Copy link
Copy Markdown

Summary

  • remove terminated existing sessions from both session registries immediately after handling the request
  • add a regression test for the clean DELETE/session termination path

Fixes #3300

Validation

  • uv run --frozen ruff format ...
  • uv run --frozen ruff check src/mcp/server/streamable_http_manager.py tests/server/test_streamable_http_manager.py
  • uv run --frozen pyright src/mcp/server/streamable_http_manager.py tests/server/test_streamable_http_manager.py
  • uv run --frozen pytest tests/server/test_streamable_http_manager.py -q (31 passed)
  • git diff --check

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 2 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread tests/server/test_streamable_http_manager.py

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 1 file (changes from recent commits).

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread tests/server/test_streamable_http_manager.py Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cleanly terminated streamable-HTTP sessions are never deregistered: the DELETE path skips its own cleanup

1 participant