Skip to content

Add Aruba AOS-CX to the Netmiko and Hier Config library mappers - #874

Open
dspatig-gdx wants to merge 3 commits into
networktocode:developfrom
dspatig-gdx:add-aruba-aoscx-hier-config-mapper
Open

Add Aruba AOS-CX to the Netmiko and Hier Config library mappers#874
dspatig-gdx wants to merge 3 commits into
networktocode:developfrom
dspatig-gdx:add-aruba-aoscx-hier-config-mapper

Conversation

@dspatig-gdx

Copy link
Copy Markdown

Closes #873

@dspatig-gdx

Copy link
Copy Markdown
Author

Adds `aruba_aoscx` → `aruba_aoscx` to `NETMIKO_LIB_MAPPER` and `HIERCONFIG_LIB_MAPPER` (and their reverses) so netutils resolves the Netmiko and hier_config driver names for Aruba AOS-CX. netmiko already exposes an `aruba_aoscx` device type; hier_config's v2→v3 resolver reads `network_driver_mappings["hier_config"]` and now gets AOS-CX instead of falling back to GENERIC. Docs tables were regenerated via `python development_scripts.py`, and a changelog fragment is included."

@jeffkala

Copy link
Copy Markdown
Collaborator

Previously aruba_aoscx was added in the section for non netmiko drivers _MAIN_LIB_MAPPER["aruba_aoscx"] = "aruba_aoscx" . I need to review a bit further. We did have a large research excersise for this previously. #588 has that context.

@dspatig-gdx

Copy link
Copy Markdown
Author

The main reason for the addition is that heir_config now has aruba_aoscx support. Netmiko does as well and this has been tested when setting network drivers to {"netmiko": {"aruba_aoscx": "aruba_aoscx"}, "hier_config": {"aruba_aoscx": "aruba_aoscx"}}

@jeffkala

Copy link
Copy Markdown
Collaborator

can you remove this line

_MAIN_LIB_MAPPER["aruba_aoscx"] = "aruba_aoscx"
? Shouldn't be needed now that you added it to the netmiko lib

Now that aruba_aoscx is in NETMIKO_LIB_MAPPER, MAIN_LIB_MAPPER inherits it
via the netmiko deep copy, so the explicit override is no longer needed.
Addresses review feedback on networktocode#874.
@dspatig-gdx

Copy link
Copy Markdown
Author

Done in 7fc57dd — dropped the explicit _MAIN_LIB_MAPPER["aruba_aoscx"] line. MAIN_LIB_MAPPER now picks it up from the netmiko deep-copy, verified it still resolves and all tests pass.

…nto add-aruba-aoscx-hier-config-mapper

# Conflicts:
#	netutils/lib_mapper.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Aruba AOS-CX to the Netmiko and Hier Config library mappers

2 participants