Skip to content

test: convert forEach to for in test-constant.js file - #65271

Closed
Nixxy25 wants to merge 1 commit into
nodejs:mainfrom
Nixxy25:my-first-contribution
Closed

test: convert forEach to for in test-constant.js file#65271
Nixxy25 wants to merge 1 commit into
nodejs:mainfrom
Nixxy25:my-first-contribution

Conversation

@Nixxy25

@Nixxy25 Nixxy25 commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

for...of is preferred over Array.prototype.forEach in the test suite:
clearer stack traces on failure, works with await, and avoids
allocating a callback per iteration.

RenderATL NodeJS Workshop

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Aug 13, 2026
@Nixxy25 Nixxy25 changed the title feat: convert forEach to for in test-constant.js file test: convert forEach to for in test-constant.js file Aug 13, 2026
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Signed-off-by: NIxxy25 <tellaoyinkansola25@gmail.com>
@Nixxy25
Nixxy25 force-pushed the my-first-contribution branch from 04032f9 to e0ace21 Compare August 14, 2026 03:45
@avivkeller avivkeller added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Aug 14, 2026
@avivkeller avivkeller added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Aug 15, 2026
@codecov

codecov Bot commented Aug 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.32%. Comparing base (f914e45) to head (e0ace21).
⚠️ Report is 31 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #65271      +/-   ##
==========================================
- Coverage   92.07%   90.32%   -1.76%     
==========================================
  Files         399      751     +352     
  Lines      177007   250000   +72993     
  Branches    27381    47224   +19843     
==========================================
+ Hits       162978   225810   +62832     
- Misses      13716    15573    +1857     
- Partials      313     8617    +8304     

see 489 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Aug 15, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/65271
✔  Done loading data for nodejs/node/pull/65271
----------------------------------- PR info ------------------------------------
Title      test: convert forEach to for in test-constant.js file (#65271)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     Nixxy25:my-first-contribution -> nodejs:main
Labels     test, code-and-learn, author ready, needs-ci, commit-queue
Commits    1
 - feat: convert forEach to for in test-constant.js file
Committers 1
 - NIxxy25 <tellaoyinkansola25@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/65271
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/65271
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 13 Aug 2026 20:05:32 GMT
   ✔  Approvals: 2
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/65271#pullrequestreview-4932942643
   ✔  - Aviv Keller (@avivkeller): https://github.com/nodejs/node/pull/65271#pullrequestreview-4934054787
   ✘  2 GitHub CI job(s) failed:
   ✘    - lint-commit-message: FAILURE (https://github.com/nodejs/node/actions/runs/31767740201/job/95027864465)
   ✘    - x86_64-darwin: with shared libraries / build: FAILURE (https://github.com/nodejs/node/actions/runs/31767740332/job/95028005259)
   ℹ  Last Full PR CI on 2026-08-14T02:32:58Z: https://ci.nodejs.org/job/node-test-pull-request/75827/
   ⚠  Commits were pushed after the last Full PR CI run:
   ⚠  - feat: convert forEach to for in test-constant.js file
- Querying data for job/node-test-pull-request/75827/
✔  Build data downloaded
- Querying failures of job/node-test-commit/90548/
✔  Data downloaded
   ✘  1 failure(s) on the last Jenkins CI run
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/31905918893

@jasnell

jasnell commented Aug 15, 2026

Copy link
Copy Markdown
Member

Note to whomever lands this: the commit message prefix will need to be manually fixed up to fix the linting.

avivkeller pushed a commit that referenced this pull request Aug 15, 2026
Signed-off-by: NIxxy25 <tellaoyinkansola25@gmail.com>
PR-URL: #65271
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
@avivkeller

Copy link
Copy Markdown
Member

Landed in 30bff4a

@avivkeller avivkeller closed this Aug 15, 2026
@avivkeller

avivkeller commented Aug 15, 2026

Copy link
Copy Markdown
Member

I've landed it with an amended commit message (the only failure was linting the commit message prior to my amendment, skipped)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants