Skip to content

test: convert test-messageevent-brandcheck forEach to for...of loop - #65279

Open
nachiketap11 wants to merge 1 commit into
nodejs:mainfrom
nachiketap11:test-messageevent-brandcheck-convert-foreach
Open

test: convert test-messageevent-brandcheck forEach to for...of loop#65279
nachiketap11 wants to merge 1 commit into
nodejs:mainfrom
nachiketap11:test-messageevent-brandcheck-convert-foreach

Conversation

@nachiketap11

Copy link
Copy Markdown

Updated the forEach loop in test-messageevent-brandcheck.js to a for...of loop for a cleaner stack trace.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Aug 14, 2026
@nachiketap11

Copy link
Copy Markdown
Author

@jasnell, tagging you for review.

@avivkeller avivkeller added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Aug 14, 2026

@Ethan-Arrowood Ethan-Arrowood left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@avivkeller avivkeller added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. request-ci Add this label to start a Jenkins CI on a PR. labels Aug 15, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 15, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@codecov

codecov Bot commented Aug 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.32%. Comparing base (1662b69) to head (d335b90).
⚠️ Report is 29 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #65279      +/-   ##
==========================================
+ Coverage   90.31%   90.32%   +0.01%     
==========================================
  Files         751      751              
  Lines      249776   250000     +224     
  Branches    47173    47238      +65     
==========================================
+ Hits       225587   225821     +234     
+ Misses      15585    15565      -20     
- Partials     8604     8614      +10     

see 44 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@avivkeller avivkeller removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants